Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo configuration #9

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Repo configuration #9

merged 4 commits into from
Aug 8, 2023

Conversation

nomaxg
Copy link

@nomaxg nomaxg commented Aug 8, 2023

Nix, CODEOWNERS, and fork sync Github action

Signed-off-by: nomaxg <[email protected]>
@nomaxg nomaxg requested a review from jbearer August 8, 2023 15:39
Signed-off-by: nomaxg <[email protected]>
Signed-off-by: nomaxg <[email protected]>
@nomaxg nomaxg changed the title Nix configuration Repo configuration Aug 8, 2023
@nomaxg nomaxg requested a review from sveitser August 8, 2023 15:56
.github/workflows/fork-sync.yml Outdated Show resolved Hide resolved
.github/workflows/fork-sync.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@sveitser
Copy link
Collaborator

sveitser commented Aug 8, 2023

I think this github action is not ideal because it fails if there are no changes and it fails if there is a PR already (instead of updating it).

I think it's worth trying https://github.com/wei/pull and see if that has a more sane behaviour.

@nomaxg
Copy link
Author

nomaxg commented Aug 8, 2023

I think this github action is not ideal because it fails if there are no changes and it fails if there is a PR already (instead of updating it).

I think it's worth trying https://github.com/wei/pull and see if that has a more sane behaviour.

Ok, let's try that instead, I'll delete fork-sync for now

@nomaxg nomaxg requested a review from jbearer August 8, 2023 16:59
@nomaxg nomaxg merged commit 9eb4764 into develop Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants