Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tree, Tree-Item] update indentation & add padding for better visual hierarchy #7096

Closed
7 tasks done
Tracked by #6632
ashetland opened this issue Jun 2, 2023 · 2 comments
Closed
7 tasks done
Tracked by #6632

[Tree, Tree-Item] update indentation & add padding for better visual hierarchy #7096

ashetland opened this issue Jun 2, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-12-17 - Dec ...

Comments

@ashetland
Copy link

ashetland commented Jun 2, 2023 •
edited by anveshmekala
Loading

Description

Update indentation and spacing fortree-items. This was outlined as part of the work to audit and update nested indentations to improve visual hierarchy across components (Epic #6632).

Acceptance Criteria

  • Update item indent value
  • Add padding
  • Add gap
  • Remove min-height
  • Remove padding around all icons
  • Correct lines alignment
  • Correct icon position in selection-mode=“ancestors”

Full Figma specs for all scales

Before/after example:
CleanShot 2024-10-28 at 08 47 09@2x

Relevant Info

No response

Which Component

Tree, Tree Item

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 2, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Jun 2, 2023
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jun 2, 2023
@ashetland ashetland mentioned this issue Jun 2, 2023
Closed
5 tasks
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jun 2, 2023
@ashetland ashetland mentioned this issue Jun 5, 2023
Open
@geospatialem geospatialem mentioned this issue Jun 15, 2023
Closed
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 26, 2023
@brittneytewks brittneytewks added the p - medium Issue is non core or affecting less that 60% of people using the library label Oct 24, 2023
@brittneytewks brittneytewks added design Issues that need design consultation prior to development. and removed figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Dec 11, 2023
@brittneytewks brittneytewks added the estimate - 5 A few days of work, definitely requires updates to tests. label Jan 29, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Aug 16, 2024
@github-actions github-actions bot added the p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone label Oct 16, 2024
@ashetland ashetland mentioned this issue Oct 24, 2024
Open
5 tasks
@ashetland ashetland changed the title tree, tree-item update indentation padding for better visual hierarchy [Tree, Tree-Item] update indentation padding for better visual hierarchy Oct 24, 2024
@ashetland ashetland changed the title [Tree, Tree-Item] update indentation padding for better visual hierarchy [Tree, Tree-Item] update indentation & padding for better visual hierarchy Oct 24, 2024
@ashetland ashetland changed the title [Tree, Tree-Item] update indentation & padding for better visual hierarchy [Tree, Tree-Item] update indentation & add padding for better visual hierarchy Oct 24, 2024
@anveshmekala anveshmekala self-assigned this Nov 22, 2024
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 25, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 4, 2024
@anveshmekala anveshmekala mentioned this issue Dec 5, 2024
Merged
anveshmekala added a commit that referenced this issue Dec 12, 2024
@anveshmekala
feat(tree,tree-item): update indentation (#10990)
5970cd3 
**Related Issue:** #7096 

## Summary
Updates padding indentation for `tree-item`'s in `tree`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 12, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 12, 2024
@geospatialem
Copy link
Member

Verified on Storybook with 3.0.0-next.60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
5 participants
@geospatialem @DitwanP @anveshmekala @ashetland @brittneytewks