Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add SortedFeatureView to base registry deserialize values method #186

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Add SortedFeatureView to base registry deserialize values method #186

merged 2 commits into from
Mar 4, 2025

Conversation

piket
Copy link
Collaborator

@piket piket commented Mar 4, 2025

SortedFeatureView was not getting properly registered.

Which issue(s) this PR fixes:

  • add SortedFeatureView to base registry deserialize_registry_values method

Misc

@piket piket changed the title fix: add SortedFeatureView to base registry deserialize values method fix: Add SortedFeatureView to base registry deserialize values method Mar 4, 2025
Manisha4
Manisha4 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@Manisha4 Manisha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@piket piket merged commit daacb48 into master Mar 4, 2025
23 of 24 checks passed
@piket piket deleted the fixSortedFeatureViewRegistration branch March 4, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manisha4 Manisha4 Manisha4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piket @Manisha4