Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add SortedFeatureView to base registry deserialize values method #186

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Add SortedFeatureView to base registry deserialize values method #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3db1b81
fix: add SortedFeatureView to base registry deserialize values method
piket Mar 4, 2025
11082e3
fix linting
piket Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/python/feast/infra/registry/base_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
from feast.protos.feast.core.Project_pb2 import Project as ProjectProto
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.protos.feast.core.SavedDataset_pb2 import SavedDataset as SavedDatasetProto
from feast.protos.feast.core.SortedFeatureView_pb2 import (
SortedFeatureView as SortedFeatureViewProto,
)
from feast.protos.feast.core.StreamFeatureView_pb2 import (
StreamFeatureView as StreamFeatureViewProto,
)
Expand Down Expand Up @@ -951,6 +954,8 @@ def deserialize_registry_values(serialized_proto, feast_obj_type) -> Any:
return SavedDatasetProto.FromString(serialized_proto)
if feast_obj_type == FeatureView:
return FeatureViewProto.FromString(serialized_proto)
if feast_obj_type == SortedFeatureView:
return SortedFeatureViewProto.FromString(serialized_proto)
if feast_obj_type == StreamFeatureView:
return StreamFeatureViewProto.FromString(serialized_proto)
if feast_obj_type == OnDemandFeatureView:
Expand Down
Loading