Add initial filtering implementations #4905
Conversation
MrRowey
added
feature: selection behavior
There was a problem hiding this comment.
Since it's not written here, according to FAForever/FA-Binary-Patches#30, this is on hold (is in draft form) because "It would likely break any UI mod that relies on how the selection works."
The PR format could be improved by splitting it up between implementing various filters and the actual new filtering. Though my biggest pain was that moving the entire OnSelectionChanged function around caused a giant diff with for just a few changes.
| unitCount = table.getn(units) | ||
|
|
||
| if unitCount > 0 then | ||
| return units, unitCount |
There was a problem hiding this comment.
It would be better to include filtered down hover + navy in this part instead of just navy.
| ignoreFiltering = false | ||
|
|
||
| else | ||
| -- do not ignore selections when holding down shift |
There was a problem hiding this comment.
| -- do not ignore selections when holding down shift | |
| -- do not filter selections when holding down shift |
| local selection, count = newSelection, originalCount | ||
| selection, count = DeselectLockedOut(selection, count) | ||
|
|
||
| if PrefsDeselectByLayer ~= 'off' then |
There was a problem hiding this comment.
Could be simplified to if PrefsDeselectByLayer then by using false for "off" in the option keys.
| return | ||
| end | ||
|
|
||
| -- allows us to ignore the deprioritzation for this selection |
There was a problem hiding this comment.
| -- allows us to ignore the deprioritzation for this selection | |
| -- the selection has already been filtered |
| ForkThread( | ||
| function() | ||
| IgnoreFiltering() | ||
| SelectUnits(selection) | ||
| end | ||
| ) |
There was a problem hiding this comment.
It seems unclear to me why SelectUnits has to be forked.
| -- Deselect Selens if necessary. Also do work on Hotbuild labels | ||
| local changed = false -- Prevent recursion | ||
| if newSelection and not table.empty(newSelection) then | ||
| newSelection, changed = DeselectSelens(newSelection) |
There was a problem hiding this comment.
| newSelection, changed = DeselectSelens(newSelection) | |
| -- Function frequently used by mods to adjust selection | |
| newSelection, changed = DeselectSelens(newSelection) |
There was a problem hiding this comment.
What was this going to be used for compared to observable? I see the difference is that it gets a value upon initialization, and that it uses the class system instead of metatables.
| local head = 1 | ||
| for k = 1, count do | ||
| local userUnit = selection[k] | ||
| if not userUnit.LockedOutOfSelection then | ||
| selection[head] = userUnit | ||
| head = head + 1 | ||
| end | ||
| end |
There was a problem hiding this comment.
I guess all of this is to preserve the table as an array? Simply doing if locked then t[i] = nil end return t, table.getn(t) leaves holes and requires a table.getn call.
MrRowey
added
the
area: requires engine patch
Closes #4892 and #4891