Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes of UEF projectiles to separate files #5658

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Nov 11, 2023

Continuation of #5652

@Garanas Garanas added the area: code style code refactoring label Nov 11, 2023
@Garanas Garanas added this to the Development iteration V milestone Nov 11, 2023
@Garanas Garanas changed the base branch from deploy/fafdevelop to develop June 1, 2024 19:36
@MrRowey MrRowey marked this pull request as ready for review June 19, 2024 09:33
@MrRowey
Copy link
Member

MrRowey commented Jun 19, 2024

I've Tested all the units by manually firing them all and their are no errors that show up in the log window

@MrRowey MrRowey merged commit 81328f0 into develop Jun 19, 2024
3 checks passed
@MrRowey MrRowey deleted the codestyle/uef-projectiles branch June 19, 2024 09:38
@Garanas
Copy link
Member Author

Garanas commented Jun 21, 2024

@MrRowey this pull request was not finished - it was in draft status for a reason. Several projectiles are now missing on deploy/fafdevelop.

Please make sure that you test the content that you merge before merging it. I can't stress this enough - spawning in the units that trigger the behavior is an absolute must. As an example:

INFO: Problems loading module '/projectiles/tdfplasma01/tdfplasma01_script.lua'.  Falling back to 'Projectile' in '/lua/sim/projectile.lua'.
WARNING: ...s.nx5\projectiles\tdfplasma01\tdfplasma01_script.lua(1): access to nonexistent global variable "TPlasmaCannonProjectile"
WARNING: stack traceback:
WARNING:         [C]: in function `error'
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\config.lua(54): in function <...er\replaydata\gamedata\lua.nx5\lua\system\config.lua:53>
WARNING:         ...s.nx5\projectiles\tdfplasma01\tdfplasma01_script.lua(1): in main chunk
WARNING:         [C]: in function `doscript'
WARNING:         [C]: ?
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(61): in function <...er\replaydata\gamedata\lua.nx5\lua\system\import.lua:41>
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): in function `import'
WARNING: Error importing /projectiles/tdfplasma01/tdfplasma01_script.lua:
         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): Error importing '/projectiles/tdfplasma01/tdfplasma01_script.lua'
         stack traceback:
         	[C]: ?
         	...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(77): in function <...er\replaydata\gamedata\lua.nx5\lua\system\import.lua:41>
         	...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): in function `import'

@MrRowey
Copy link
Member

MrRowey commented Jun 21, 2024

@MrRowey this pull request was not finished - it was in draft status for a reason. Several projectiles are now missing on deploy/fafdevelop.

Please make sure that you test the content that you merge before merging it. I can't stress this enough - spawning in the units that trigger the behavior is an absolute must. As an example:

INFO: Problems loading module '/projectiles/tdfplasma01/tdfplasma01_script.lua'.  Falling back to 'Projectile' in '/lua/sim/projectile.lua'.
WARNING: ...s.nx5\projectiles\tdfplasma01\tdfplasma01_script.lua(1): access to nonexistent global variable "TPlasmaCannonProjectile"
WARNING: stack traceback:
WARNING:         [C]: in function `error'
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\config.lua(54): in function <...er\replaydata\gamedata\lua.nx5\lua\system\config.lua:53>
WARNING:         ...s.nx5\projectiles\tdfplasma01\tdfplasma01_script.lua(1): in main chunk
WARNING:         [C]: in function `doscript'
WARNING:         [C]: ?
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(61): in function <...er\replaydata\gamedata\lua.nx5\lua\system\import.lua:41>
WARNING:         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): in function `import'
WARNING: Error importing /projectiles/tdfplasma01/tdfplasma01_script.lua:
         ...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): Error importing '/projectiles/tdfplasma01/tdfplasma01_script.lua'
         stack traceback:
         	[C]: ?
         	...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(77): in function <...er\replaydata\gamedata\lua.nx5\lua\system\import.lua:41>
         	...er\replaydata\gamedata\lua.nx5\lua\system\import.lua(164): in function `import'

I literally spawned in every unit and manually fired them in my test and encountered no issues... Hence why I merged it in. The error above I fixed in my testing so not sure what's happened here. I spend a hour testing each unit fired and fixed any issues that came up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code style code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants