Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes of Cybran projectiles to separate files #5669

Closed
wants to merge 10 commits into from

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Nov 14, 2023

No description provided.

@MrRowey MrRowey added the area: code style code refactoring label Nov 14, 2023
@MrRowey MrRowey assigned Garanas and unassigned Garanas Nov 14, 2023
@MrRowey MrRowey requested a review from Garanas November 14, 2023 20:29
@Garanas
Copy link
Member

Garanas commented Jan 1, 2024

WARNING: Unable to find file /lua/sim/projectiles/cybran/cheavyelectronbolterprojectile2.lua
WARNING: stack traceback:
WARNING:         [C]: in function `doscript'
WARNING:         [C]: ?
WARNING:         d:\faf-development\fa\lua\system\import.lua(61): in function <d:\faf-development\fa\lua\system\import.lua:41>
WARNING:         d:\faf-development\fa\lua\system\import.lua(161): in function `import'
WARNING:         d:\faf-development\fa\lua\system\import.lua(137): in function `import'
WARNING:         d:\faf-development\fa\lua\cybranprojectiles.lua(33): in main chunk
WARNING:         [C]: in function `doscript'
WARNING:         [C]: ?
WARNING:         d:\faf-development\fa\lua\system\import.lua(61): in function <d:\faf-development\fa\lua\system\import.lua:41>
WARNING:         d:\faf-development\fa\lua\system\import.lua(161): in function `import'
WARNING:         d:\faf-development\fa\lua\system\import.lua(137): in function `import'
WARNING:         ...cifmissiletactical01\cifmissiletactical01_script.lua(1): in main chunk
WARNING:         [C]: in function `doscript'
WARNING:         [C]: ?
WARNING:         d:\faf-development\fa\lua\system\import.lua(61): in function <d:\faf-development\fa\lua\system\import.lua:41>
WARNING:         d:\faf-development\fa\lua\system\import.lua(161): in function `import'

@MrRowey please make sure you've run the game with your changes. You can check the log for warnings and errors:

image

Make sure that you've toggled the warning and error boxes:

image

@Garanas Garanas added this to the Development iteration V milestone Jan 1, 2024
@MrRowey MrRowey marked this pull request as draft January 15, 2024 11:26
@Garanas Garanas changed the base branch from deploy/fafdevelop to develop June 1, 2024 19:36
@MrRowey MrRowey requested a review from lL1l1 June 12, 2024 12:32
@MrRowey MrRowey marked this pull request as ready for review June 12, 2024 12:32
@MrRowey
Copy link
Member Author

MrRowey commented Jun 12, 2024

Spawned in all usnits and no script errors

@MrRowey
Copy link
Member Author

MrRowey commented Jul 9, 2024

@clyfordv @Hdt80bro @lL1l1 Can anyone test and see if my test were fine

@MrRowey MrRowey closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code style code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants