Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the majority of the remaining blueprint files #6272

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Jun 19, 2024

Continuation of #6271

The only blueprint files that are not formatted are the emitter files. It would merge the key-based and value-based fields, creating a bit of a mess. Luckily we won't be doing much (if any) batch processing on those type of files.

With this we can now finally start batch processing file empowered by the Brewlan WikiGen made by @The-Balthazar. This would empower us to do various edits to units, props and projectiles an mass and bake them right into the blueprint files.

@Garanas Garanas added the area: code style code refactoring label Jun 19, 2024
@Garanas Garanas merged commit 1d2ab1d into develop Jun 19, 2024
3 checks passed
@Garanas Garanas deleted the code-style/format-all-blueprints branch June 19, 2024 17:26
@Basilisk3
Copy link
Collaborator

@Garanas What do we do with the campaign-related and miscellaneous units? E.g.: https://github.com/FAForever/fa/blob/develop/units/XAC0101/XAC0101_unit.bp

@Garanas
Copy link
Member Author

Garanas commented Jun 19, 2024

We can include them if we want, but how the blueprints are now is also harmless. What would you prefer?

@Basilisk3
Copy link
Collaborator

I never used them for anything. If the memory gains are negligible, then the only advantage I can think of is uniformity. There are a lot of these units, so maybe it is worth it. But only if the amount of time required is reasonable, of course👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: code style code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants