Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the map preview for now #6548

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Hide the map preview for now #6548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f0049
Hide the map preview for now
Garanas Nov 21, 2024
65e31e0
Update the snippet
Garanas Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion changelog/snippets/features.6479.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
- (#6479) Rework the in-game matchmaker lobby from the ground up

From a user perspective the matchmaker lobby now has a map preview and a connection matrix. The map preview can help the players to understand what they'll be gating into. The connection matrix can help players to understand what source (a player) is connected to what source (another player). The diagonal represents what sources (other players) the local client is connected to. When you receive a message from a peer then it blinks the corresponding box in the matrix.
From a user perspective there should be essentially no changes. A new connection matrix is introduced that can help players to understand what source (a player) is connected to what source (another player). The diagonal represents what sources (other players) the local client is connected to. When you receive a message from a peer then it blinks the corresponding box in the matrix.

There are further features ready such as a map preview that can help you prepare for the match ahead. That is not shown however until we have better tooling in place to gauge its impact.

From a developers perspective the matchmaker lobby is now maintainable. You can now start the matchmaker lobby locally through your development environment. This allows you to run the matchmaker lobby as if you would find a match in the client. The matchmaker lobby is build from the ground up with maintainability in mind. It now supports a hot reload-like functionality for the interface. This allows you to change the interface on the go, without having to relaunch the game.

Expand Down
5 changes: 3 additions & 2 deletions lua/ui/lobby/autolobby/AutolobbyInterface.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,9 @@ local AutolobbyInterface = Class(Group) {
self.State.PlayerOptions = playerOptions

if pathToScenarioInfo and playerOptions then
self.Preview:Show()
self.Preview:UpdateScenario(pathToScenarioInfo, playerOptions)
-- hide it for now until we have a better way to decipher its possible (negative) impact
-- self.Preview:Show()
-- self.Preview:UpdateScenario(pathToScenarioInfo, playerOptions)
end
end,

Expand Down
Loading