Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate AddBlinkyBox #6577

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Dec 8, 2024

Description of the proposed changes

Annotate AddBlinkyBox, now we know what it does!

Testing done on the proposed changes

AddBlinkyBox.demo.mp4

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added area: ui Anything to do with the User Interface of the Game type: intellisense labels Dec 8, 2024
@lL1l1 lL1l1 added this to the Development I of 2025 milestone Dec 8, 2024
@lL1l1 lL1l1 marked this pull request as ready for review December 8, 2024 06:33
@Garanas Garanas merged commit 508885d into FAForever:develop Dec 12, 2024
5 checks passed
@4z0t
Copy link
Member

4z0t commented Dec 25, 2024

I wonder how it can be used 🤔

@Garanas
Copy link
Member

Garanas commented Dec 25, 2024

Maybe we can use it to highlight (relevant) units that receive damage. There is a callback for that in gamemain.lua if I am not mistaken.

@4z0t
Copy link
Member

4z0t commented Dec 25, 2024

Yeah, there is one.

@lL1l1
Copy link
Contributor Author

lL1l1 commented Dec 26, 2024

I think it could've been used to highlight units in the tutorial, it's a typical "click me!" type of thing across games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game type: intellisense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants