Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the projectile in the OnMissileIntercepted callback #6601

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

maudlin27
Copy link
Contributor

As certain information may be included on the projectile that is of interest to AI when the missile is intercepted

Description of the proposed changes

Adds the projectile to the onmissileintercepted callback, for if the projectile contains information of use to the AI.

Testing done on the proposed changes

Did a destructive hook of the code change to check it provided the desired functionality.

Additional context

The target position provided from the callback is unreliable; this way when a projectile is created I can record against the projectile the intended unit target, and then access this when the intercepted callback is triggered.

As certain information may be included on the projectile that is of interest to AI when the missile is intercepted
@maudlin27
Copy link
Contributor Author

If any issues with this or want to discuss please ping me on discord; I've already covered the scenario with a destructive hook for M28 but figured it'd be worth adding to core functionality to be of benefit more generally

@Garanas
Copy link
Member

Garanas commented Dec 27, 2024

@relent0r I think we spoke of this a few days ago, what are your thoughts about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the definition in the unit class to include the additional parameter.

@relent0r
Copy link
Contributor

@relent0r I think we spoke of this a few days ago, what are your thoughts about this?

If its what I think it is its a little different. Maudlin found that when the Aeon TMD intercepted missiles the position being returned by the callback was the TMD rather than the target position. I believe this was a way that Maudlin could track what happened to the missile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants