Remove the chat sound when watching a replay #6646
Open
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lL1l1
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
The current implementation of the chat beep doesn't make sense so removing it is okay. There is a chat beep UI mod (ChatBeepLite) that has a more reasonable design (beeps only for ally chat/private chat messages). Maybe that could be a feature to implement with configuration options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This refers to the sound when you receive a message. The sound plays in replays. I personally find it to be an annoying sound, but this is of course subjective.
Checklist