Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order button tooltips not disappearing on mouse exit #6654

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Feb 14, 2025

Issue

#6173 broke the mouse exit behavior because it didn't update all usages of the tooltip, under the incorrect assumption that the create function would return a Control that can be destroyed by the rest of the code like usual.

Description of the proposed changes

Update the remaining code for the order button tooltips to use the Tooltip class correctly.

Testing done on the proposed changes

Mouse over order buttons then move the mouse away and the tooltips should disappear. Previously the order button tooltips would only disappear when a new tooltip was created.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added type: bug area: ui Anything to do with the User Interface of the Game labels Feb 14, 2025
@lL1l1 lL1l1 marked this pull request as ready for review February 15, 2025 00:00
@lL1l1
Copy link
Contributor Author

lL1l1 commented Feb 15, 2025

This has some mod conflicts when they try to add new order buttons :/
Mods: M28AI, Advanced Target Priorities Tweaked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant