Fix mod manager invalid fallback icon #6663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lL1l1
added
area: ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a mod specifies an invalid icon in its mod info, it overwrites the default value from here:
fa/lua/MODS.LUA
Line 510 in 9a6ddd0
The mod manager verifies that this icon file exists, and it uses a fallback icon if it doesn't, but the fallback is invalid, so a warning gets printed to the log and the icon becomes a yellow missing texture.
Description of the proposed changes
fix the fallback file
Testing done on the proposed changes
Mods with invalid icons show the generic icon instead of a missing texture.
Checklist
- [ ] Changes are annotated, including comments where useful