Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intellisense plugin #6682

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Mar 1, 2025

Description of the proposed changes

Use the text replacement functionality of the intellisense plugin for the following:

  • Fix the syntax errors caused by {&n &n} by replacing it with {}
  • Implement intellisense for hook files by prepending the hooked file to the hooking file.

Separately:

  • Add comments for the old plugin changes (replacing # with --)

Testing done on the proposed changes

Use the test commit to try the changes.

Ctrl shift U to open the output log
switch output to Lua
Find log file
Open log file directory
There should be a diff.lua file, which lets you see what intellisense sees as you edit

Additional context

Another idea would be to automatically add function overloads for Class calls because currently they don't propagate types properly.

A lot of features on the language server's wiki don't work because we are 2-3 years out of date, such as generics. I tried the up to date version and it was enjoyable but clearly was missing features we need to work with fa.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

lL1l1 added 5 commits March 2, 2025 13:46
Ctrl shift U to open the output log
switch output to Lua
Find log file
Open log file directory
There should be a diff.lua file, which lets you see what intellisense sees
This reverts commit dd7bebb8b84ef23ee4af0a129521ef2d6b3e1dc2.
@lL1l1 lL1l1 force-pushed the annotations/plugin-fix branch from 45f1a41 to c651bb3 Compare March 2, 2025 21:46
lL1l1 added 3 commits March 2, 2025 15:38
It breaks tooltips by displacing the result of mousing over certain chars by the length of "pairs(", so generally if you mouse over the beginning you get the pairs func, and tooltips for any fields being accessed are also displaced.
This reverts commit 0973e3e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant