Skip to content

Fix issue where players added or removed from friend or foe lists did not have games updated #2346

Fix issue where players added or removed from friend or foe lists did not have games updated

Fix issue where players added or removed from friend or foe lists did not have games updated #2346

Triggered via pull request September 11, 2024 14:28
Status Failure
Total duration 6m 9s
Artifacts

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
unit-test: tests/integration_tests/test_game.py#L810
test_restore_game_session_live[qstream] AssertionError: assert [{'player_ids...'team_id': 2}] == [{'player_ids...'team_id': 2}] At index 1 diff: {'team_id': 2, 'player_ids': []} != {'team_id': 2, 'player_ids': [3]} Full diff: [ { 'player_ids': [ 1, ], 'team_id': 1, }, { - 'player_ids': [ + 'player_ids': [], ? ++ - 3, - ], 'team_id': 2, }, ]
unit-test: tests/integration_tests/test_server.py#L606
test_game_info_broadcast_to_players_in_lobby[qstream] AssertionError: assert {'command': '...'custom', ...} == {'command': '...ustom', ...}]} Omitting 1 identical items, use -vv to show Left contains 21 more items: {'enforce_rating_range': False, 'featured_mod': 'faf', 'game_type': 'custom', 'host': 'friends', 'hosted_at': '2024-09-11T14:31:20.092368+00:00', 'launched_at': None, 'map_file_path': 'maps/scmp_007.zip', 'mapname': 'scmp_007', 'max_players': 12, 'num_players': 2, 'password_protected': False, 'rating_max': None, 'rating_min': None, 'rating_type': 'global', 'sim_mods': {}, 'state': 'open', 'teams': {'1': ['friends', 'test']}, 'teams_ids': [{'player_ids': [10, 1], 'team_id': 1}], 'title': 'New Title', 'uid': 41956, 'visibility': 'friends'} Right contains 1 more item: {'games': [{'command': 'game_info', 'enforce_rating_range': False, 'featured_mod': 'faf', 'game_type': 'custom', 'host': 'friends', 'hosted_at': '2024-09-11T14:31:20.092368+00:00', 'launched_at': None, 'map_file_path': 'maps/scmp_007.zip', 'mapname': 'scmp_007', 'max_players': 12, 'num_players': 2, 'password_protected': False, 'rating_max': None, 'rating_min': None, 'rating_type': 'global', 'sim_mods': {}, 'state': 'closed', 'teams': {'1': ['friends', 'test']}, 'teams_ids': [{'player_ids': [10, 1], 'team_id': 1}], 'title': 'Friends Only', 'uid': 41956, 'visibility': 'friends'}]} Full diff: { 'command': 'game_info', + 'enforce_rating_range': False, + 'featured_mod': 'faf', + 'game_type': 'custom', + 'host': 'friends', + 'hosted_at': '2024-09-11T14:31:20.092368+00:00', + 'launched_at': None, + 'map_file_path': 'maps/scmp_007.zip', + 'mapname': 'scmp_007', + 'max_players': 12, + 'num_players': 2, + 'password_protected': False, + 'rating_max': None, + 'rating_min': None, + 'rating_type': 'global', + 'sim_mods': {}, + 'state': 'open', - 'games': [ ? ^ - ^ + 'teams': { ? ^^ ^ + '1': [ + 'friends', + 'test', + ], + }, + 'teams_ids': [ { - 'command': 'game_info', - 'enforce_rating_range': False, - 'featured_mod': 'faf', - 'game_type': 'custom', - 'host': 'friends', - 'hosted_at': '2024-09-11T14:31:20.092368+00:00', - 'launched_at': None, - 'map_file_path': 'maps/scmp_007.zip', - 'mapname': 'scmp_007', - 'max_players': 12, - 'num_players': 2, ? ---- ^^ + 'player_ids': [ ? +++ ^ - 'password_protected': False, - 'rating_max': None, - 'rating_min': None, - 'rating_type': 'global', - 'sim_mods': {}, - 'state': 'closed', - 'teams': { - '1': [ ? - ^^^^ + 10, ? ^^ - 'friends', - 'test', - ], ? ^ + 1, ? ^ - }, - 'teams_ids': [ - { - 'player_ids': [ - 10, - 1, - ], - 'team_id': 1, - }, ], - 'title': 'Friends Only', - 'uid': 41956, ? ^ - --- + 'team_id': 1, ? ^^^^^ - 'visibility': 'friends', }, ]
unit-test: tests/integration_tests/test_server.py#L606
test_game_info_broadcast_to_players_in_lobby[json] AssertionError: assert {'command': '...'custom', ...} == {'command': '...ustom', ...}]} Omitting 1 identical items, use -vv to show Left contains 21 more items: {'enforce_rating_range': False, 'featured_mod': 'faf', 'game_type': 'custom', 'host': 'friends', 'hosted_at': '2024-09-11T14:31:20.338181+00:00', 'launched_at': None, 'map_file_path': 'maps/scmp_007.zip', 'mapname': 'scmp_007', 'max_players': 12, 'num_players': 2, 'password_protected': False, 'rating_max': None, 'rating_min': None, 'rating_type': 'global', 'sim_mods': {}, 'state': 'open', 'teams': {'1': ['friends', 'test']}, 'teams_ids': [{'player_ids': [10, 1], 'team_id': 1}], 'title': 'New Title', 'uid': 41956, 'visibility': 'friends'} Right contains 1 more item: {'games': [{'command': 'game_info', 'enforce_rating_range': False, 'featured_mod': 'faf', 'game_type': 'custom', 'host': 'friends', 'hosted_at': '2024-09-11T14:31:20.338181+00:00', 'launched_at': None, 'map_file_path': 'maps/scmp_007.zip', 'mapname': 'scmp_007', 'max_players': 12, 'num_players': 2, 'password_protected': False, 'rating_max': None, 'rating_min': None, 'rating_type': 'global', 'sim_mods': {}, 'state': 'closed', 'teams': {'1': ['friends', 'test']}, 'teams_ids': [{'player_ids': [10, 1], 'team_id': 1}], 'title': 'Friends Only', 'uid': 41956, 'visibility': 'friends'}]} Full diff: { 'command': 'game_info', + 'enforce_rating_range': False, + 'featured_mod': 'faf', + 'game_type': 'custom', + 'host': 'friends', + 'hosted_at': '2024-09-11T14:31:20.338181+00:00', + 'launched_at': None, + 'map_file_path': 'maps/scmp_007.zip', + 'mapname': 'scmp_007', + 'max_players': 12, + 'num_players': 2, + 'password_protected': False, + 'rating_max': None, + 'rating_min': None, + 'rating_type': 'global', + 'sim_mods': {}, + 'state': 'open', - 'games': [ ? ^ - ^ + 'teams': { ? ^^ ^ + '1': [ + 'friends', + 'test', + ], + }, + 'teams_ids': [ { - 'command': 'game_info', - 'enforce_rating_range': False, - 'featured_mod': 'faf', - 'game_type': 'custom', - 'host': 'friends', - 'hosted_at': '2024-09-11T14:31:20.338181+00:00', - 'launched_at': None, - 'map_file_path': 'maps/scmp_007.zip', - 'mapname': 'scmp_007', - 'max_players': 12, - 'num_players': 2, ? ---- ^^ + 'player_ids': [ ? +++ ^ - 'password_protected': False, - 'rating_max': None, - 'rating_min': None, - 'rating_type': 'global', - 'sim_mods': {}, - 'state': 'closed', - 'teams': { - '1': [ ? - ^^^^ + 10, ? ^^ - 'friends', - 'test', - ], ? ^ + 1, ? ^ - }, - 'teams_ids': [ - { - 'player_ids': [ - 10, - 1, - ], - 'team_id': 1, - }, ], - 'title': 'Friends Only', - 'uid': 41956, ? ^ - --- + 'team_id': 1, ? ^^^^^ - 'visibility': 'friends', }, ],
unit-test: tests/unit_tests/test_lobbyconnection.py#L679
test_command_social_add_friend assert set() == {2} Extra items in the right set: 2 Full diff: + set() - { - 2, - }
unit-test: tests/unit_tests/test_lobbyconnection.py#L690
test_command_social_add_friend_idempotent sqlalchemy.exc.IntegrityError: (pymysql.err.IntegrityError) (1062, "Duplicate entry '1-2' for key 'PRIMARY'") [SQL: INSERT INTO friends_and_foes (user_id, subject_id, status) VALUES (%s, %s, %s)] [parameters: (1, 2, 'FRIEND')] (Background on this error at: https://sqlalche.me/e/20/gkpj)
unit-test
Process completed with exit code 1.
docker-build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
unit-test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/