Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init m2m client #504

Merged
merged 1 commit into from
Dec 1, 2023
Merged

init m2m client #504

merged 1 commit into from
Dec 1, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 29, 2023

Huge PR, but most of it are automatic code-style fixes and the "relocation" of all backend files into src/backend.

closes #505
closes #507
closes #495
closes #488
relates and fixes some issies with #478
preparation for #445

Whats in it?

  • The new m2m client
  • leaderboard reactivated for normal users
  • All "backend" files are moved to src/backend, this has the advantage of having a cleaner structure and simpler config for linters, webpack etc.
  • Introducing AppKernel and retiring fafApp, this makes testing and understanding whats going on simpler and rubust
  • Introducting ServiceContainer to reduce the clutter with config/functions/classes everywhere, reduce duplicated code and make testing soo much easier
  • Fixing report player, this time i took my time to actually fix it
  • Some minor fixes here and there

@fcaps fcaps force-pushed the feature/m2mClient branch from 1564de4 to e7d2401 Compare November 29, 2023 07:08
@fcaps fcaps closed this Dec 1, 2023
@fcaps fcaps force-pushed the feature/m2mClient branch from e7d2401 to 1b76c3e Compare December 1, 2023 02:09
@fcaps fcaps reopened this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 554 lines in your changes are missing coverage. Please review.

Comparison is base (29b71cb) 43.56% compared to head (d8435a3) 46.22%.
Report is 1 commits behind head on develop.

Files Patch % Lines
src/backend/routes/views/account/get/report.js 4.16% 46 Missing ⚠️
src/backend/routes/views/account/post/register.js 11.62% 38 Missing ⚠️
src/backend/routes/views/account/post/report.js 7.31% 38 Missing ⚠️
src/backend/routes/views/account/post/linkGog.js 13.88% 31 Missing ⚠️
...ackend/routes/views/account/post/changePassword.js 15.15% 28 Missing ⚠️
...c/backend/routes/views/account/get/connectSteam.js 10.34% 26 Missing ⚠️
src/backend/cron-jobs/wordpressCacheCrawler.js 16.66% 25 Missing ⚠️
src/backend/routes/views/account/post/activate.js 16.66% 25 Missing ⚠️
.../routes/views/account/post/confirmPasswordReset.js 16.66% 25 Missing ⚠️
src/backend/cron-jobs/leaderboardCacheCrawler.js 18.51% 22 Missing ⚠️
... and 30 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    43.56%   46.22%   +2.66%     
===========================================
  Files           50       56       +6     
  Lines         1173     1205      +32     
  Branches       140      131       -9     
===========================================
+ Hits           511      557      +46     
+ Misses         648      634      -14     
  Partials        14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps fcaps force-pushed the feature/m2mClient branch from d9c76b8 to 2a14a6e Compare December 1, 2023 16:38
@fcaps fcaps marked this pull request as ready for review December 1, 2023 16:39
@fcaps fcaps force-pushed the feature/m2mClient branch from 2a14a6e to d8435a3 Compare December 1, 2023 16:54
@fcaps fcaps merged commit 52e8501 into FAForever:develop Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to start node if services are down Lazy load services Code Style/Linter Report User Broken
1 participant