Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_dict_info_to_list test on Windows #1066

Merged
merged 1 commit into from
May 28, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 24, 2024

Description

The dtype value of a np.array created from a list of integers is platform dependent, i.e.:

  • np.array([0]).dtype is np.int64 on Linux/macOS or
  • np.array([0]).dtype is np.int32 on Windows

The test_dict_info_to_list hardcodes the expectation that np.array([0]).dtype is np.int64, this PR fixes this to fix the test_dict_info_to_list test on Windows.

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 7ac7b29 into Farama-Foundation:main May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants