SISL/Multiwalker env MO Port #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure why I am getting this final error. It is claiming that the object I am indexing is |
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.dekcBjReVV/Listeners
LC_TERMINAL_VERSION=3.4.21
COLORFGBG=15;0
ITERM_PROFILE=Main
XPC_FLAGS=0x0
PWD=/Users/ucak/MOMAS/momadm-bechmarks
SHELL=/bin/zsh
__CFBundleIdentifier=com.googlecode.iterm2
LC_CTYPE=UTF-8
TERM_PROGRAM_VERSION=3.4.21
TERM_PROGRAM=iTerm.app
PATH=/Users/ucak/MOMAS/momadm-bechmarks/.venv/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
LC_TERMINAL=iTerm2
COLORTERM=truecolor
COMMAND_MODE=unix2003
TERM=xterm-256color
HOME=/Users/ucak
TMPDIR=/var/folders/s5/3px3g159399c2l1bm_n1bw4c0000gn/T/
USER=ucak
XPC_SERVICE_NAME=0
LOGNAME=ucak
ITERM_SESSION_ID=w0t0p0:8A09846D-45E4-45E6-9AFE-C591885D192A
__CF_USER_TEXT_ENCODING=0x0:0:0
SHLVL=1
OLDPWD=/Users/ucak/MOMAS
ZSH=/Users/ucak/.oh-my-zsh
HOMEBREW_PREFIX=/opt/homebrew
HOMEBREW_CELLAR=/opt/homebrew/Cellar
HOMEBREW_REPOSITORY=/opt/homebrew
MANPATH=/opt/homebrew/share/man::
INFOPATH=/opt/homebrew/share/info:
PAGER=less
LESS=-R
LSCOLORS=Gxfxcxdxbxegedabagacad
LS_COLORS=di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43
VIRTUAL_ENV=/Users/ucak/MOMAS/momadm-bechmarks/.venv
PS1=(.venv) %(?:%{�[01;32m%}➜ :%{�[01;31m%}➜ ) %{�[36m%}%c%{�[00m%} $(git_prompt_info)
VIRTUAL_ENV_PROMPT=(.venv)
_=/usr/bin/env, , functions
|
The failed test is for deterministic environments, not applicable to Multiwalker. All other tests pass. 👍 |
ffelten
requested changes
Oct 17, 2023
umutucak
commented
Oct 19, 2023
| rewards[i][1] = self.fall_reward # not all, only the one that fell | ||
| if self.remove_on_fall: | ||
| walker._destroy() | ||
| if not self.terminate_on_fall: |
There was a problem hiding this comment.
Should this not be if self.terminate_on_fall? This is for giving everyone the termination penalty on top of the falling penalty if the setting is toggled.
There was a problem hiding this comment.
I changed it to be like this, but if I'm wrong we can revert.
umutucak
commented
Oct 19, 2023
| if self.remove_on_fall: | ||
| walker._destroy() | ||
| if not self.terminate_on_fall: | ||
| rewards[:][1] = self.terminate_reward |
There was a problem hiding this comment.
Should this be rewards[:, 2] for the 3rd objective (pkg not falling)? Which objective should be penalize for terminate_on_fall?
ffelten
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've vectorized all the rewards in the sisl/multiwalker env from PZ to be MO
Objectives