Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SISL/Multiwalker env MO Port #5
SISL/Multiwalker env MO Port #5
Changes from 21 commits
bc1a81e
1f3b8a4
6bd7727
b2c9bcf
7ba1864
ca76e94
d370d5c
24ee56d
9687560
9b22950
9b6cc40
e4a3a5f
d03b970
6104432
236ff4a
3f7dc6c
b2a36f0
072cbe7
95a9da0
c7e7637
1923bdb
c932805
debe0b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be
if self.terminate_on_fall
? This is for giving everyone the termination penalty on top of the falling penalty if the setting is toggled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to be like this, but if I'm wrong we can revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
rewards[:, 2]
for the 3rd objective (pkg not falling)? Which objective should be penalize forterminate_on_fall
?