added (de)serializers for Kotlin unsigned number types #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes_Feature. (cherry picked from commit 59ea94c)
dinomite
approved these changes
Feb 28, 2021
Comment on lines
+89
to
97
| return when { | ||
| type.isInterface && type.rawClass == Sequence::class.java -> SequenceDeserializer | ||
| type.rawClass == Regex::class.java -> RegexDeserializer | ||
| type.rawClass == UByte::class.java -> UByteDeserializer | ||
| type.rawClass == UShort::class.java -> UShortDeserializer | ||
| type.rawClass == UInt::class.java -> UIntDeserializer | ||
| type.rawClass == ULong::class.java -> ULongDeserializer | ||
| else -> null | ||
| } |
There was a problem hiding this comment.
when is one of my favorite Kotlin features, I'm happy every time I see it.
|
Do I already have a valid contributor agreement? |
|
@efenderbosch I thought so… |
|
@dinomite @efenderbosch I don't think so, with a quick look I didn't see one (via relevant gmail account or cla repo). I may have assumed there was one based on two other CLAs that I received (sometimes get names mixed up in my mind, not for CLAs themselves). |
|
sent CLA via email |
|
CLA received & filed so we are good now. Thank you @efenderbosch for following up on this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #182