Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades the runtime to node20, now that 16 is EoL #344

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

bkendall
Copy link
Collaborator

No description provided.

@bkendall bkendall requested a review from jhuleatt February 21, 2024 20:37
Copy link

github-actions bot commented Feb 21, 2024

Visit the preview URL for this PR (updated for commit bbc39f0):

https://action-hosting-deploy-demo--pr344-bk-node20-mw7qfbq4.web.app

(expires Wed, 06 Mar 2024 20:40:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ca07ce2c831b1990b78fcf2ecdfe230a486dc973

Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bkendall!

@testak-m
Copy link

testak-m commented Mar 9, 2024

@bkendall @jhuleatt
Can this pull request be merged and released?
You can solve the following issues.
#341

@sam-golioth
Copy link

@bkendall @jhuleatt Is there anything else we need to merge this PR?

@huggsboson
Copy link

@bkendall any chance you'll merge this soon?

@testak-m
Copy link

@bkendall @jhuleatt
ping

@thomasvht
Copy link

Will someone have a look, because due to the EoL we have builds failing.

@testak-m
Copy link

@inlined
Is it possible to merge this pull request?
This action is used in firebase-tools.

@thomasvht
Copy link

@henrylangenhoven I see the changes are approved which is great. Is there someone who can merge the change? 😄

@testak-m
Copy link

@developit
hello!
I found your name in the author field.

author: "Jason Miller (https://github.com/developit) and Firebase"

I have a request for you, the author.
Could you please merge and release this pull request?
please!

@developit
Copy link

I don't have merge rights on this repo, sorry.

@testak-m
Copy link

@developit
I understand your position.
Thank you for checking.

@testak-m
Copy link

@jhuleatt
Are you still busy?
Don't have time to merge and release this pull request?

@EricCheungAO
Copy link

@jhuleatt Are you still busy? Don't have time to merge and release this pull request?

cc @jhuleatt

@testak-m
Copy link

He seems to be active.
FirebaseExtended/firebase-framework-tools#161

I was relieved to know that he was alive.

@jhuleatt jhuleatt merged commit ac8041b into main Apr 15, 2024
8 checks passed
@lesv
Copy link

lesv commented Apr 17, 2024

Does anyone know what version this is. The CLI is still generating FirebaseExtended/action-hosting-deploy@v0, is the updated one v1? (and has it been released to Github)

@testak-m
Copy link

@lesv
It seems that it has been merged but not released.
https://github.com/FirebaseExtended/action-hosting-deploy/releases

It has not been released and cannot be used in any version.
v0 refers to v0.7.1.

@testak-m
Copy link

@jhuleatt
Can you release it?

@testak-m
Copy link

@jamesdaniels @leoortizz @Yuangwang @sjjj986 @bkendall
He seems busy.
Can you guys help him make the release?

@178inaba
Copy link
Contributor

I submitted a pull request to firebase-tools to specify the version by hash value.
The warning should disappear once released.
firebase/firebase-tools#7025

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.