Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro-tests): Use stable Astro Config APIs #203

Merged
merged 4 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-dogs-grab.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@inox-tools/astro-tests': minor
---

Use stable Astro APIs
4 changes: 3 additions & 1 deletion packages/astro-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"@astrojs/internal-helpers": "catalog:",
"@astrojs/markdown-remark": "^5.3.0",
"@inox-tools/utils": "workspace:^",
"astro": "catalog:",
"debug": "catalog:",
"fast-glob": "^3.3.2",
"shiki": "^1.24.0",
Expand All @@ -45,5 +44,8 @@
"typescript": "catalog:",
"vite": "catalog:",
"vitest": "catalog:"
},
"peerDependencies": {
"astro": "catalog:"
}
}
23 changes: 11 additions & 12 deletions packages/astro-tests/src/astroFixture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import fastGlob from 'fast-glob';
import { Agent, request } from 'undici';
import { build, dev, preview, sync } from 'astro';
import type { AstroConfig, AstroInlineConfig } from 'astro';
import { mergeConfig } from '../node_modules/astro/dist/core/config/merge.js';
import { validateConfig } from '../node_modules/astro/dist/core/config/validate.js';
import { getViteConfig } from 'astro/config';
import { getViteConfig, mergeConfig, validateConfig } from 'astro/config';
import { callsites } from './utils.js';
import type { App } from 'astro/app';
import { getDebug } from './internal/log.js';
Expand Down Expand Up @@ -154,8 +152,9 @@ let nextDefaultPort = 10000 + Math.floor(Math.random() * 40000);
* });
* ```
*/
export async function loadFixture(inlineConfig: InlineConfig): Promise<Fixture> {
if (!inlineConfig?.root) throw new Error("Must provide { root: './fixtures/...' }");
export async function loadFixture({ root, ...remaining }: InlineConfig): Promise<Fixture> {
if (!root) throw new Error("Must provide { root: './fixtures/...' }");
const inlineConfig: AstroInlineConfig = remaining;

debug('Setting default log level to "silent"');
// Silent by default during tests to not pollute the console output
Expand All @@ -179,14 +178,13 @@ export async function loadFixture(inlineConfig: InlineConfig): Promise<Fixture>
inlineConfig.server.port ??= nextDefaultPort++;
}

let root = inlineConfig.root;
if (typeof root !== 'string') {
// Handle URL, should already be absolute so just convert to path
root = fileURLToPath(root);
inlineConfig.root = fileURLToPath(root);
} else if (root.startsWith('file://')) {
debug('Root is a file URL, converting to path');
// Handle "file:///C:/Users/fred", convert to "C:/Users/fred"
root = fileURLToPath(new URL(root));
inlineConfig.root = fileURLToPath(new URL(root));
} else if (!path.isAbsolute(root)) {
debug('Root is a relative path, resolving to absolute path relative to caller');
const [caller] = callsites().slice(1);
Expand All @@ -196,19 +194,20 @@ export async function loadFixture(inlineConfig: InlineConfig): Promise<Fixture>
}
debug(`Fixture loaded from ${callerUrl}`);
// Handle "./fixtures/...", convert to absolute path relative to the caller of this function.
root = fileURLToPath(new URL(root, callerUrl));
inlineConfig.root = fileURLToPath(new URL(root, callerUrl));
debug(`Resolved fixture root to ${root}`);
} else {
inlineConfig.root = root;
}

inlineConfig.root = root;
const config = await validateConfig(inlineConfig, root, 'dev');
const config = await validateConfig(inlineConfig, inlineConfig.root, 'dev');

debug('Output dir:', config.outDir);
debug('Src dir:', config.srcDir);

const viteConfig = await getViteConfig(
{},
{ ...inlineConfig, root }
inlineConfig
)({
command: 'serve',
mode: 'dev',
Expand Down
Loading
Loading