feat(astro-tests): Use stable Astro Config APIs #203
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request introduces a minor version update for the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Caller
participant L as loadFixture
participant V as getViteConfig
C->>L: Call loadFixture(inlineConfig)
L->>L: Destructure inlineConfig to (root, ...remaining)
alt root not provided
L->>C: Throw error ("Missing root")
else root provided
L->>L: Process and validate root (URL/path conversions)
L->>V: Call getViteConfig(inlineConfig)
V-->>L: Return Vite config
L->>C: Return Fixture object
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fryuni
changed the title
Fryuni
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/astro-tests/package.json (1)
47-50: Good dependency management change.Moving Astro from
dependenciestopeerDependenciesis a sound architectural decision, allowing consumers to provide their own version of Astro and preventing potential duplicate installations.This change provides more flexibility and follows best practices for libraries that integrate with frameworks but don't need to bundle them.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
.changeset/late-dogs-grab.md(1 hunks)packages/astro-tests/package.json(1 hunks)packages/astro-tests/src/astroFixture.ts(4 hunks)pnpm-workspace.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changeset/late-dogs-grab.md
⏰ Context from checks skipped due to timeout of 120000ms (1)
- GitHub Check: E2E test
🔇 Additional comments (6)
pnpm-workspace.yaml (1)
2-2: Astro version update matches PR objectives.The version bump from
^5.2.5to^5.4.0aligns with the PR's goal of using stable Astro Config APIs introduced in version 5.4.0.packages/astro-tests/src/astroFixture.ts (5)
8-8: Proper imports for the Astro Config API.The import statement now explicitly includes all the necessary functions from astro/config, improving code clarity and maintainability.
155-157: Improved function signature with better parameter handling.The function signature has been refactored to destructure the
rootproperty directly, which makes the code more readable and allows for better error handling.The early validation of the
rootparameter with a clear error message is a good practice that improves developer experience.
183-201: Streamlined root path handling.The refactored code directly assigns to
inlineConfig.rootinstead of using a separate variable, reducing complexity while maintaining the same functionality.The code correctly handles various formats of the
rootparameter (string, URL, relative, absolute).
203-203: Direct use of inlineConfig.root in validateConfig.Using
inlineConfig.rootdirectly in thevalidateConfigcall simplifies the code.
208-211: Simplified getViteConfig call.The refactored code removes unnecessary object spreading and directly passes
inlineConfigtogetViteConfig.
Summary by CodeRabbit
New Features
Chores
Refactor