Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate_limited decorator doesn't pass type checker #33

Open
jamesbraza opened this issue Nov 19, 2024 · 0 comments
Open

rate_limited decorator doesn't pass type checker #33

jamesbraza opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jamesbraza
Copy link
Contributor

I tried to add --doctest-modules to pytest, but it doesn't work because the rate_limited decorator (from Future-House/paper-qa#520) doesn't pass typeguard.

In that PR we got rate_limited to pass mypy via type: ignore comments, but typeguard is not mypy. We should fix the typing of rate_limited.
@jamesbraza jamesbraza added the bug Something isn't working label Nov 19, 2024
@jamesbraza jamesbraza transferred this issue from Future-House/paper-qa Jan 9, 2025
This was referenced Jan 22, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesbraza