This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Refactor LLMs #37
Merged
Refactor LLMs #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultipleCompletionsLLMModel is deprecated
jamesbraza
reviewed
Jan 21, 2025
maykcaldas
force-pushed
the
refactor-llms
branch
from
bbae4a2 to
b8321ca
Compare
jamesbraza
reviewed
Jan 22, 2025
| assert results.text | ||
|
|
||
| # @pytest.mark.vcr(match_on=[*VCR_DEFAULT_MATCH_ON, "body"]) | ||
| assert isinstance(results, list) |
There was a problem hiding this comment.
Can we consolidate any tests now?
jamesbraza
reviewed
Jan 22, 2025
This also renamed achat to acompletion to align better with litellm interface
It seems some entries had the old 'platform_system' marker due my old uv version. Now it is updated to 'sys_platform'
maykcaldas
force-pushed
the
refactor-llms
branch
from
e714677 to
83f1f85
Compare
gpt-4o-mini was renamed to OPENAI_TEST, gpt-4o to GPT_4O, and gpt-3.5-turbo to GPT_35. As support to gpt-3.5-turbo-instruct was dropped, these tests were adapted to ANTHROPIC_TEST
* Added .mailmap so pre-commit passes * Many fixes to typing in llms * Formatted cassettes
jamesbraza
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
I am not sure all of these cassettes needed to be regenerated. For example with this one, it seems compatible
It's nice to not do extra regenerations, makes it clearer what actually changed
maykcaldas
force-pushed
the
refactor-llms
branch
2 times, most recently
from
331657a to
21688b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.