Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Improve unique email validation #4103

Merged
merged 7 commits into from
Sep 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions api/app/GraphQL/Validators/UpdateUserInputValidator.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<?php

namespace App\GraphQL\Validators;

use Illuminate\Validation\Rule;
use Nuwave\Lighthouse\Validation\Validator;

final class UpdateUserInputValidator extends Validator
{
/**
* Return the validation rules.
*
* @return array<string, array<mixed>>
*/
public function rules(): array
{
return [
'email' => [
'sometimes',
'nullable',
/**
* Note: Ignore the email for the user passed
* in when executing the mutation so it is not
* included in the unique check. This is required
* for allowing a user to be updated while the email
* remains the same.
*
* REF: https://laravel.com/docs/9.x/validation#rule-unique
*/
Rule::unique('users', 'email')->ignore($this->arg('id'), 'id'),
petertgiles marked this conversation as resolved.
Show resolved Hide resolved
]
];
}

/**
* Return the validation messages
*/
public function messages(): array
{
return [
'email.unique' => 'This email address is already in use',
];
}
}
Loading