Bug - Improve unique email validation

[esizer]

Summary

This resolves an issue with not being able to update an existing user due to the unique email validation by ignoring the user you are updating.

Testing

1. Regenerate the queries npm run codegen --workspaces
2. Build all projects npm run production --workspaces
3. Navigate tot /admin/users/
4. Edit a user and update field other than email
5. Ensure you can save the user
6. Edit it again, using an existing email
7. Ensure you get the unique email error
8. Navigate to /talent/profile
9. Go to to the "About Me" form and repeat steps 4-7
10. Logout and register as a new user
11. Attempt to create account with an existing email
12. Ensure you get the unique email error

[petertgiles]

What bug does this fix? How do we test it?

[vd1992]

What bug does this fix? How do we test it?

https://talent-cloud.slack.com/archives/C0259G6KXJ6/p1664382823644029

[esizer]

What bug does this fix? How do we test it?

Sorry @petertgiles . I was in such a rush to get this up I forgot to write a proper description with testing instructions.

Essentially, when we added the unique email rule for /create-account it was also triggering for updates and would not allow a user to update their own account since their email already existed. This ignores the user email marching the id passed to the mutation.

[petertgiles]

when we added the unique email rule for /create-account it was also triggering for updates

Oh no! That's what I get for ignoring Cypress I guess. 🤦 Thanks for fixing this so quickly.

[esizer]

Oh no! That's what I get for ignoring Cypress I guess. 🤦 Thanks for fixing this so quickly.

Felt responsible since I approved it. I don't like that cypress is being marked as "skipped" rather than "failed" right now.

[esizer]

@petertgiles Sorry, I did not realize the massive diff for schema.gql. The important lines are:

gc-digital-talent/api/graphql/schema.graphql

Lines 975 to 977 in b0bbd90

	input UpdateUserAsAdminInput
	@validator(class: "App\\GraphQL\\Validators\\UpdateUserInputValidator") {
	id: ID

gc-digital-talent/api/graphql/schema.graphql

Lines 1042 to 1044 in b0bbd90

	input UpdateUserAsUserInput
	@validator(class: "App\\GraphQL\\Validators\\UpdateUserInputValidator") {
	id: ID

[petertgiles]

Nice job! This fixes the error for me. Two small things to check on.

[petertgiles]

I think you got it! 🏅

[patcon]

Thanks a million @esizer! I think this may have resolved everything after #4108 🎉