Add more context to errors - constitutive/ files #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SourceContext to know where Groups/Wrappers has been declared - Added a test for the node & attribute line infos
…y/2320-xml-errors-feedback" - using getSourceContext() instead of getPath()
…ack-3' into feature/rey/error-xml-line-2-errors-impacting
- also renaming FileContext to DataFileContext
- code refactoring + doc edit
+ virtual destructors
…l-line-constitutive
(used string_view to support raw string loading)
…S-DEV/GEOS into feature/rey/error-xml-line-2
…xml-line-constitutive
Note that ConstitutiveBase::getFullName() needs further decisions & development. Merge remote-tracking branch 'origin/feature/rey/error-xml-line-2' into feature/rey/error-xml-line-constitutive
…xml-line-constitutive
TotoGaz
approved these changes
Sep 14, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the features added the PR #2404 to add more context to the errors messages of classes in
src/coreComponents/contitutivefiles.In particular, this PR aims to add the lines of the XML elements from which an error message comes from.
See issue and attached files describing error message changes: #2320