Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pull request approval by engineering #524

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Clarify pull request approval by engineering #524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e62efa
Clarify pull request approval by engineering
aduth Mar 11, 2024
8435cb5
Refine "Who reviews" language
aduth Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _articles/pull-request-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ changes from outside.

[github-repositories]: {% link _articles/github.md %}#repositories

- **Who merges**: once there is at least one approving review, the author
merges their own pull request.
- **Who merges**: once there is at least one approving review by a member of
the engineering team, the author merges their own pull request.

- In rare circumstances where a merge is time-sensitive and the pull request
author is unavailable, it may be acceptable for another to merge on their
Expand Down
Loading