Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate (QA | ARCHIVER | REPORT) extensions to catalog.data.gov #3957

Closed
7 tasks done
nickumia-reisys opened this issue Sep 15, 2022 · 9 comments
Closed
7 tasks done
Assignees
Labels
CKAN component/catalog Related to catalog component playbooks/roles Feature

Comments

@nickumia-reisys
Copy link
Contributor

nickumia-reisys commented Sep 15, 2022

User Story

In order to restore dilapidated features on catalog.data.gov, the Data.gov Catalog team wants to re-integrate ckanext-qa, ckanext-archiver and ckanext-report.

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

Background

[Any helpful contextual notes or links to artifacts/evidence, if needed]

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

[Notes or a checklist reflecting our understanding of the selected approach]

  • Incorporate the extensions into a local test environment
  • Inspect how the extensions work with some test data
  • Add tests
  • Deploy to development on cloud.gov
  • Fix bugs (if there are any)
  • Deploy to production
@nickumia-reisys
Copy link
Contributor Author

List of things that work and don't work

ckan report generate openness -- OK

image

ckan qa update -- OK

image
image

ckan report list -- OK

image

Visiting /report -- OK

image

Visiting /report/broken-links -- OK

image

Visiting /report/openness -- NOT OK

Openness scores on datasets -- NOT OK

Openness scores on resources -- NOT OK

@nickumia-reisys
Copy link
Contributor Author

cf run-task catalog-web -c "ckan report generate openness" -k 2G -m 2G

  • Took 6 mins to complete 28834 datasets on development
  • ETA for prod: 270 mins

@nickumia-reisys
Copy link
Contributor Author

cf run-task catalog-web -c "ckan qa update" -k 2G -m 2G

  • Took 3 mins to complete 28834 dataset on development
  • ETA for prod: 135 mins

@nickumia-reisys
Copy link
Contributor Author

Note: We are on a fork of ckanext-qa

@jbrown-xentity
Copy link
Contributor

Note: We are on a fork of ckanext-qa

Do we want to attempt to merge these changes back upstream? That might be a separate ticket... Or were there more changes than just the PR above?

@nickumia-reisys
Copy link
Contributor Author

So... archiver tries to use Redis to process the archival queue, but falls back to celery if there is an ImportError 😕

It looks like it's falling back to celery, but I'm not sure why...
image

Since celery is not installed, the openness score is not computed per dataset.


Do we want to attempt to merge these changes back upstream? That might be a separate ticket... Or were there more changes than just the PR above?

@jbrown-xentity That was the only PR. We can try to merge it upstream. But I think upstream is still supporting PY2, so we'd have to do a conditional iteritems for PY2 and items for PY3. When they completely drop support for PY2, it's an easy merge upstream.. but right now, I don't think they'll take it.

@nickumia-reisys
Copy link
Contributor Author

This is the solution to getting the queue to finish!!

We need to specify the queue that has the work to do when calling ckan jobs worker

ckan jobs worker bulk

@nickumia-reisys
Copy link
Contributor Author

Welp... looks like they don't care about PY2 support after all, Yay!

The above PR fixes two issues. The .items() issue and the template not found issue 😅

@nickumia-reisys
Copy link
Contributor Author

Also going to note, at least we know of at least one CKAN instance that is actively use the QA extension, Finnish Digital Agency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CKAN component/catalog Related to catalog component playbooks/roles Feature
Projects
Archived in project
Development

No branches or pull requests

3 participants