Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in matrix-style tracks height computation and fixed CI #105

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

StefanoCretti
Copy link
Contributor

When using style=matrix, PlotHicMat.get_track_height still multiplied track height by 0.8. This was probably the previous way of getting a roughly equal aspect ratio of the matrix since margins were not kept into account in frame width computation. Now that frame width computation is fixed, it actually breaks the aspect ratio.

Likely caused by me forgetting to remove the multiplier when frame width computation formula was fixed.

When using style=matrix, PlotHicMat.get_track_height still multiplied track height by 0.8. This was probably the previous way of getting a roughly equal aspect ratio of the matrix since margins were not kept into account in frame width computation. Now that frame width computation is fixed, it actually breaks the aspect ratio.

Likely caused by me forgetting to remove the multiplier when frame width computation formula was fixed.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.87%. Comparing base (6432254) to head (c50d509).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
coolbox/core/track/hicmat/plot.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   39.74%   39.87%   +0.12%     
==========================================
  Files          81       81              
  Lines        5271     5440     +169     
==========================================
+ Hits         2095     2169      +74     
- Misses       3176     3271      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StefanoCretti StefanoCretti changed the title Bug fix in matrix-style tracks height computation Bug fix in matrix-style tracks height computation and fixed CI Feb 25, 2025
@StefanoCretti
Copy link
Contributor Author

Also fixed CI by:

  • forcing sqlite installation from conda-forge when testing
  • updated codecov github action (1 -> 5)
    Given the maintenance status of the repository it might be better to drop codecov altogether (to avoid bot comments in PR), but leaving it in since it was there initially.

@Nanguage Nanguage merged commit 1e72791 into GangCaoLab:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants