Remove Java custom armor trims when translating item to Bedrock to prevent visual issues #4548
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removing the Trim tag entirely
|
Thanks! I think the recent betas introduced some degree of support for custom trims, but happy to add this is a stopgap until we do something with that assuming no one has any objections. |
Kas-tle
reviewed
Apr 4, 2024
| @@ -33,6 +33,7 @@ | |||
| import org.geysermc.geyser.session.GeyserSession; | |||
|
|
|||
| public class ArmorItem extends Item { | |||
| private static final String MINECRAFT_NAMESPACE = "minecraft:"; | |||
There was a problem hiding this comment.
You can just use the string inline as that seems to be what we've done in the rest of the codebase.
|
Custom trims are already possible, but they would need to be defined via resource packs - but yeah this is a good enough solution for now |
|
I have tried to research a bit as to whether or not custom armor trims are a thing on Bedrock but didn't find much - if you've got anything documenting it I'd be interested! |
Kas-tle
approved these changes
Apr 4, 2024
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
…event visual issues (GeyserMC#4548) * Fix (or workaround) armor items with custom armor trims having no texture on bedrock * Fix armor items with custom trims causing issues on entity models by removing the Trim tag entirely * Refer to minecraft namespace inline for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've implemented a small fix regarding custom armor trims created using Java datapacks. Armor pieces with custom trims render on Bedrock as though they have a missing model/texture, and additionally, the item looks blank when in inventory.
As far as I know, Bedrock doesn't have the ability to add custom armor trims yet, so my fix was to entirely discard the armor trim NBT tag when translating a Java item to a Bedrock item.
Without fix:
With fix: