WIP: Update Tailwind to 3.4 to allow subgrid and update news card to use subgrid as example. #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipakmdhrm
changed the title
|
More work is needed here. subgrid elements are inheriting the parent's gap which is messing with the gap between elements. |
amitaibu
reviewed
Dec 21, 2024
| $description = $this->wrapTextLineClamp($summary, 4); | ||
|
|
||
| return [ | ||
| '#theme' => 'server_theme_element__news_card', |
There was a problem hiding this comment.
We should not take this approach. Our approach is in fact the exact opposite. We prefer to break down those twigs, in favor of composing elements -- just like in the existing code.
amitaibu
reviewed
Dec 21, 2024
Comment on lines
+487
to
+497
| $info['server_theme_element__news_card'] = [ | ||
| 'variables' => [ | ||
| 'image' => NULL, | ||
| 'labels' => NULL, | ||
| 'date' => NULL, | ||
| 'title' => NULL, | ||
| 'description' => NULL, | ||
| 'url' => NULL, | ||
| ], | ||
| ]; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
You'll notice for Desktop and Tablet that after using subgrid, each element of a card is in alignment with the corresponding element of all other cards in the same row, which wasn't the case before subgrid. Check description for eg.