Add instruction for maintainer permissions #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfredric
reviewed
Dec 15, 2023
Getting-Started.md
Outdated
| @@ -75,13 +75,16 @@ Once you've confirmed that your set is passing checks in your local branch, you | |||
|
|
|||
| 2. [Create a PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) to pull your branch into the master. | |||
|
|
|||
| 1. You may need to resolve merge conflicts. | |||
| 3. You may need to resolve merge conflicts. | |||
There was a problem hiding this comment.
IMO all of these should be 1., to take advantage of Markdown's automatic numbering (so we don't have to manually update it for PRs like this).
You can see that Markdown doesn't actually care that this is 1. in the current version, it still renders it as 3. in the generated output. The rest of the numbering is also correct in the rendered output, despite being wrong in the current .md source file.
Getting-Started.md
Outdated
| 2. Check the "Actions" tab to confirm the status of the run triggered by your request. | ||
| 6. Check the "Actions" tab to confirm the status of the run triggered by your request. | ||
|
|
||
| 7. [Enable upstream repository maintainer permissions on your pull request.](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) |
There was a problem hiding this comment.
Suggested change
| 7. [Enable upstream repository maintainer permissions on your pull request.](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) | |
| 7. If you want your PR to be merged in a timely manner, please [enable repository maintainer permissions on your pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests). |
Getting-Started.md
Outdated
| 6. Check the "Actions" tab to confirm the status of the run triggered by your request. | ||
|
|
||
| 7. [Enable upstream repository maintainer permissions on your pull request.](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) | ||
| This will allow the maintainers of the RWS repo to resolve any conflicts and merge your pull request when the time comes. If you do not do this and a conflict exists at time of merge, the maintainers will have to wait for <b>you</b> to resolve this before they can merge it, even if it is otherwise passing the checks. |
There was a problem hiding this comment.
Suggested change
| This will allow the maintainers of the RWS repo to resolve any conflicts and merge your pull request when the time comes. If you do not do this and a conflict exists at time of merge, the maintainers will have to wait for <b>you</b> to resolve this before they can merge it, even if it is otherwise passing the checks. | |
| This allows the maintainers of the RWS repository to resolve merge conflicts on your behalf. Without this permission, the maintainers must wait for **you** to resolve any conflicts before they can merge your PR, even if it is otherwise passing the checks. This will delay your submission; maintainers will not revisit your PR until the next regular review. |
|
Looks like you've passed all of the checks! |
cfredric
approved these changes
Dec 15, 2023
cfredric
pushed a commit
to cfredric/chrome-first-party-sets
that referenced
this pull request
Mar 11, 2024
* Add instruction for maintainer permissions * rephrasing and formatting as advised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently instruct uploaders to allow the RWS repo maintainers to make changes to their pull requests when they file it. These permissions are needed when there is a merge conflict so that the RWS admin on review can resolve the conflicts and merge the PR when applicable.