Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for maintainer permissions #174

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Add instruction for maintainer permissions #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c0b310
Add instruction for maintainer permissions
sjledoux Dec 15, 2023
7194c2d
rephrasing and formatting as advised
sjledoux Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Getting-Started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,18 @@ Once you've confirmed that your set is passing checks in your local branch, you

1. [Push](https://docs.github.com/en/get-started/using-git/pushing-commits-to-a-remote-repository) your local changes to your remote branch by using the command `git push origin your-branch-name`.

2. [Create a PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) to pull your branch into the master.
1. [Create a PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) to pull your branch into the master.

1. You may need to resolve merge conflicts.

4. Wait for all actions to finish running to confirm whether your PR has passed or failed the checks. 
1. Wait for all actions to finish running to confirm whether your PR has passed or failed the checks. 

1. Sometimes, especially if you had merge conflicts that you had to squash, a checkmark will appear before the action has actually run.

2. Check the "Actions" tab to confirm the status of the run triggered by your request.
1. Check the "Actions" tab to confirm the status of the run triggered by your request.

1. If you want your PR to be merged in a timely manner, please [enable repository maintainer permissions on your pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests).
This allows the maintainers of the RWS repository to resolve merge conflicts on your behalf. Without this permission, the maintainers must wait for **you** to resolve any conflicts before they can merge your PR, even if it is otherwise passing the checks. This will delay your submission; maintainers will not revisit your PR until the next regular review.

Per the Submission Guidelines, approved PRs will be manually merged in batches to the canonical RWS list once per week (Tuesdays at 12pm Eastern Time).

Expand Down
Loading