feat: implement an apt resolver #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
apt_installer
branch
3 times, most recently
from
5514193 to
16f4d50
Compare
thesayyn
force-pushed
the
apt_installer
branch
5 times, most recently
from
d9fa23d to
35e959e
Compare
thesayyn
commented
Mar 15, 2024
version lib more progress statusd docs
thesayyn
force-pushed
the
apt_installer
branch
5 times, most recently
from
3bca5d7 to
b33a243
Compare
|
ping @alexeagle for Bazel API review |
alexeagle
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
looks mostly good.
Want to make sure you handled some edge cases, I remember adding test cases for weird multiline parsing: https://github.com/GoogleContainerTools/distroless/blob/8166efb13d435c5b95bf3ff44b1479bd94403f9b/debian_package_manager/internal/deb/parser_test.go#L48
That's done already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.