Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add channel field to query context #183

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat: add channel field to query context #183

merged 3 commits into from
Jul 30, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jul 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Add patch add source field to query context to help us to track which protocol the traffic comes from

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@sunng87 sunng87 changed the title feat: add source field to query context feat: add channel field to query context Jul 26, 2024
@sunng87 sunng87 marked this pull request as ready for review July 29, 2024 06:15
@sunng87 sunng87 mentioned this pull request Jul 29, 2024
Merged
3 tasks
@sunng87 sunng87 requested a review from shuiyisong July 29, 2024 12:07
@shuiyisong shuiyisong enabled auto-merge (squash) July 30, 2024 12:12
fengys1996
fengys1996 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong merged commit c437b55 into main Jul 30, 2024
6 checks passed
@shuiyisong shuiyisong deleted the feat/query-context-source branch July 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuiyisong shuiyisong shuiyisong approved these changes

@fengys1996 fengys1996 fengys1996 approved these changes

@zyy17 zyy17 Awaiting requested review from zyy17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunng87 @fengys1996 @shuiyisong