-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 5 Unity classes + Fix X-mirroring of models #103
Open
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz
wants to merge
5
commits into
HearthSim:master
Choose a base branch
from
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−15
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e01aae1
Add 3 colliders
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz 4865694
Add 3 colliders
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz b47696f
Add MeshRenderer & reduce code
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz b953aa4
Add MeshFilter
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz e529954
Fix x-mirroring of models
j5rlLqM-rvsrY96V-GpVJP0F-IZFesRzy-ShMoz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,4 +39,4 @@ class VertexData(Object): | |
|
||
|
||
class MeshFilter(Component): | ||
pass | ||
mesh = field("m_Mesh") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was done to convert from left-handed coordinates to right-handed coordinates, FWIW. So without this the face normals would all be inside out in tools that expect right-handed models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, um, TBH I thought pull requests would only add the commits from before they were made.
Either way, you are correct, however removing the
-
on line 31 inverts the models once, so the face normals are as they should.I know it's a bit counter-intuitive but if you test it, it should be fine.