Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql mysql-client 8.3.0 #160037

Merged
merged 22 commits into from
Jan 29, 2024
Merged

mysql mysql-client 8.3.0 #160037

merged 22 commits into from
Jan 29, 2024

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 16, 2024
@bevanjkay bevanjkay force-pushed the mysql-8.3.0 branch 4 times, most recently from 8f1a637 to e1d2e5b Compare January 16, 2024 23:25
@bevanjkay bevanjkay added the long build Set a long timeout for formula testing label Jan 17, 2024
@bevanjkay bevanjkay added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 17, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 17, 2024
@bevanjkay bevanjkay added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jan 17, 2024
@bevanjkay
Copy link
Member Author

mysql++ is failing due to the deprecation of mysql_kill() and mysql_refresh() in 8.3.0 - https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html
Has only had ~300 downloads in the last year, and no releases for 3 years, maybe deprecate?

@chenrui333
Copy link
Member

yeah, we can just notify the upstream and deprecate it.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 17, 2024
@bevanjkay
Copy link
Member Author

bevanjkay commented Jan 17, 2024

@bevanjkay bevanjkay added the in progress Stale bot should stay away label Jan 18, 2024
@bevanjkay bevanjkay force-pushed the mysql-8.3.0 branch 4 times, most recently from 3bee258 to d9f8b9f Compare January 22, 2024 23:08
@bevanjkay bevanjkay added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 23, 2024
@bevanjkay
Copy link
Member Author

bevanjkay commented Jan 23, 2024

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 23, 2024
@bevanjkay bevanjkay added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 23, 2024
@bevanjkay
Copy link
Member Author

bevanjkay commented Jan 23, 2024

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 23, 2024
@bevanjkay bevanjkay added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 29, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 29, 2024
@bevanjkay bevanjkay added the ready to merge PR can be merged once CI is green label Jan 29, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 29, 2024
Merged via the queue into Homebrew:master with commit f5c6266 Jan 29, 2024
12 checks passed
@bevanjkay bevanjkay mentioned this pull request Jan 29, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants