Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Added two more SM300 IOC available to load (
SM300_02
andSM300_03
).To test
Note:
SM300_DEVICE_PREFIX
,get_default_ioc_dir()
on line 45 has an optional paramiocnum
that needs assigning otherwise it takes default value 1 and starts the wrong IOC!_02
and_03
will reportmacLib: macro MSTP1 is undefined
andmacLib: macro MSTP2 is undefined
- this is as they are new IOCs (so will not have assignments in config/globals), but also becauseconfig.xml
seems to fail to assign them a default value.Acceptance criteria
Code Review
Functional Tests
..._0n
wheren>1
) run correctlymacLib: macro
to find instances ofmacLib: macro [macro name] is undefined...
Final steps