Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 4461 #725

Closed
wants to merge 4 commits into from
Closed

Ticket 4461 #725

wants to merge 4 commits into from

Conversation

boeuf-codes
Copy link
Contributor

@boeuf-codes boeuf-codes commented Sep 12, 2022

Description of work

Added two more SM300 IOC available to load (SM300_02 and SM300_03).

To test

Note:

  • when testing these IOCs using the sm300 module, as well as changingSM300_DEVICE_PREFIX, get_default_ioc_dir() on line 45 has an optional param iocnum that needs assigning otherwise it takes default value 1 and starts the wrong IOC!
  • log files for _02 and _03 will report macLib: macro MSTP1 is undefined and macLib: macro MSTP2 is undefined - this is as they are new IOCs (so will not have assignments in config/globals), but also because config.xml seems to fail to assign them a default value.
  • creating these IOCs has unearthed some problems with some of SM300's macros, see: SM300: Issue with definition and use of MSTP macros IBEX#7349

Acceptance criteria

  • The SMC300 IOC (listed as SM300) directory has 3 IOCs available to load, with the st.cmd elements transitioned to common files as appropriate

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@boeuf-codes boeuf-codes deleted the Ticket_4461 branch October 11, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants