Support to post initialise sql connections #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts.EntitiyFactoryFunc.WithInit() checked for contracts.Initer every time. Now it is only done once in common.NewSyncSubject().
This also requires explicit handling of custom variables as we need to multiplex the original values to handle flat custom variables.
….com/goccy/go-yaml ... not to have GPLv2<->Apache 2.0 (app<->deps) license conflicts.
Make {NotificationHistory,StateHistory,History*}#Id UUID -> SHA1
With this change Icinga DB will insert the environment after each heartbeat takeover if it does not already exist in the database as the environment may have changed, although this is likely to happen very rarely, Instead of checking whether the environment already exists, uses an INSERT statement that does nothing if it does.
The default environment of Icinga is the empty string. In Golang, the zero value of string is also the empty string. But it makes sense to distinguish whether the name is not set or set to the empty string. That is possible with this change.
If the environment changes during runtime, we have to restart HA in order to stop a possibly running config sync and start a new one.
Previously, we selected each entity from the database. Now we only select entities that belong to the current environment.
Icinga/icinga2#9036 introduced a new environment ID for Icinga DB that's written to the icinga:stats stream as field "icingadb_environment". This commit updates the code to make use of this ID instead of the one derived from the Icinga 2 Environment constant.
There's a small risk that when the environment ID changes, Icinga DB could update write into the wrong environment in the database. Therefore, Icinga/icinga2#9036 introduced a new default environment ID based on the CA public key so that there should be no cases where it's required to change the actual environment ID. So if this happens nonetheless, just bail out.
Fix flawed config keys and validation
Better handling of multiple environments
Rename driver names to `icinga-*sql`
`ColumnMap` provides a cached mapping of structs exported fields to their database column names. By default, all exported struct fields are mapped to their database column names using snake case notation. The `-` (hyphen) directive for the db tag can be used to exclude certain fields. Since `ColumnMap` uses cache, the returned slice MUST NOT be modified directly.
database: Introduce `ColumnMap`
Add go github workflows
Allow to dynamically define type constraint name
In Galera clusters wsrep_sync_wait=7 lets statements catch up all pending sync between nodes first. This way new child rows await fresh parent ones from other nodes not to run into foreign key errors. MySQL single nodes will reject this with error 1193 "Unknown system variable" which is OK.
Conflicts with the `timeout` variable in `ha.go` file.
julianbrost
requested changes
Apr 5, 2024
| }, | ||
| } | ||
|
|
||
| rdb := it.MysqlDatabase() |
There was a problem hiding this comment.
We don't want to make the icinga-go-library module depend on icinga-testing as that would mean that all its dependencies would be pulled into its users, including Docker. That's one of the reasons why tests/ in Icinga DB is a separate Go module so that these dependencies are kept separate from the main module.
Note that I also would take the opportunity to add tests for more of the database code. Like starting a database externally, passing the connection details to the tests, for example in environment variables, then filling a database config struct with these values, and use this to connect. That would then serve as the basis for more tests in this project and also avoid the aforementioned dependency.
|
Main branch was force pushed because the latest version of the Icinga Go library and the library code in the Icinga DB have diverged. Please create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs Icinga/icingadb#711