Use singleton for db and redis connections #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
use-singleton-for-db-and-redis-connections
branch
from
5fd0272 to
8af314a
Compare
This was referenced Dec 17, 2024
raviks789
reviewed
Dec 17, 2024
nilmerg
force-pushed
the
use-singleton-for-db-and-redis-connections
branch
from
96e85db to
c57298e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for an upcoming change. Though, I wanted to change this already a long time ago.
There's absolutely no need to have several open connections to the same database. Which was the case before, since the connection was established for each user (class) of the
Databasetrait.But with PDO, queries are by default all serially processed. Only for MySQL it is possible to change this, by disabling query buffering.
But Icinga DB Web is incompatible anyway, with disabled query buffering, and so changing this to a singleton is fine in my opinion.
I've deliberately kept the
Databasetrait, to not update all usages of it. In case only the connection is required, the trait still has its use.