Fetch instance state (e.g. 'running'/'stopped') for EC2 instances. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything preventing this PR from being merged? We find it not good that the "terminated" instances are still fetched and considered "valid", we have to wait until they get deleted by AWS (happens after an hour or more). This makes monitoring of autoscaling groups or another dynamic environments not optimal. With this PR we could filter out instances in "Terminated" state from being imported. |
|
@Thomas-Gelf could you review this? Or even better... merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar solution to the one in #12, but a little simpler and more flexible.
By just storing the state name the user has the choice on what to do with that information.
Using the 'Replace' property modifier to replace 'running' with 'false', and then using the
'MakeBoolean' property modifier to turn the values into booleans ('false' -> false and everything else to true),
the same behavior can be achieved as in #12.