fixed the healthcheck probes taking twice (#44)

* fixed the healthcheck probes taking twice * update version * updated the healthcheck type condition
Improwised · Jul 6, 2023 · 46b332f · 46b332f
1 parent f3daa15
commit 46b332f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/charts/polymorphic-app/Chart.yaml b/charts/polymorphic-app/Chart.yaml
@@ -4,5 +4,5 @@ description: A Helm chart for deploying any custom applications, specifically po
 maintainers:
   - name: improwised
 type: application
-version: 1.2.3
+version: 1.2.4
 appVersion: 1.0.0
diff --git a/charts/polymorphic-app/templates/service.yaml b/charts/polymorphic-app/templates/service.yaml
@@ -138,8 +138,7 @@ spec:
             timeoutSeconds: 7
             initialDelaySeconds: {{ .healthcheck.initialDelaySeconds | default $.Values.serviceTemplate.healthcheck.initialDelaySeconds | default "20" }}
             periodSeconds: {{ .healthcheck.periodSeconds | default $.Values.serviceTemplate.healthcheck.periodSeconds | default "20" }}            
-          {{- end }}
-          {{- if and (or (eq .healthcheck.type "tcpSocket") (eq $.Values.serviceTemplate.healthcheck.type "tcpSocket")) (or .healthcheck.port $.Values.serviceTemplate.healthcheck.port) }}
+          {{- else if and (or (eq .healthcheck.type "tcpSocket") (eq $.Values.serviceTemplate.healthcheck.type "tcpSocket")) (or .healthcheck.port $.Values.serviceTemplate.healthcheck.port) }}
           livenessProbe:
             tcpSocket:
               port: {{ .healthcheck.port | default $.Values.serviceTemplate.healthcheck.port }}

diff --git a/charts/polymorphic-app/values.yaml b/charts/polymorphic-app/values.yaml
@@ -36,8 +36,8 @@ serviceTemplate:
   healthcheck:
     enabled: false
     type: httpGet
-    path: /healthz
-    port: http
+    # path: /healthz
+    # port: http
     # initialDelaySeconds: 30
     # periodSeconds: 30