Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid int overflow when using fillr in negative coords #1711

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Avoid int overflow when using fillr in negative coords #1711

merged 1 commit into from
Jun 5, 2022

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner April 20, 2022 01:27
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 20, 2022
NotMyFault
NotMyFault approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, looks good

@SirYwell
Copy link
Member

This should probably be upstreamed instead.

@dordsor21
Copy link
Member Author

The upstream PR that would be cherry-picked here most likely EngineHub/WorldEdit#2082

@dordsor21 dordsor21 marked this pull request as draft April 23, 2022 14:01
@dordsor21 dordsor21 force-pushed the fix/fillr-negative-y branch 2 times, most recently from 4306af4 to 70fa59c Compare May 4, 2022 13:59
@dordsor21 dordsor21 marked this pull request as ready for review May 4, 2022 13:59
@dordsor21
Copy link
Member Author

I've implemented the same fix being PRed to EH. Since that's still sitting there, we should probably go ahead and implement here anyway.

@NotMyFault NotMyFault requested a review from a team May 10, 2022 23:08
SirYwell
SirYwell approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can integrate it for now.

@NotMyFault NotMyFault merged commit 32231b4 into main Jun 5, 2022
@NotMyFault NotMyFault deleted the fix/fillr-negative-y branch June 5, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@SirYwell SirYwell SirYwell approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"minY <= maxY required" when using /fillr below Y0 and no depth parameter is specified
3 participants
@dordsor21 @SirYwell @NotMyFault