Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XP Channel for wildfly-jar-maven-plugin #125

Closed
wants to merge 1 commit into from
Closed

Conversation

tommaso-borgato
Copy link
Collaborator

@tommaso-borgato tommaso-borgato commented Dec 19, 2023

TODO: once #126 is merged, rebase and add XP channel parameters to class deployments/intersmash-deployments-provider/src/main/java/org/jboss/intersmash/deployments/WildflyDeploymentApplicationConfiguration.java and update its generateAdditionalMavenArgs() method to pass them along to the upcoming build;

Description

This PR completes and integrates the wildfly-deployments-build.eapxp profile in order to configure a single channel for xp builds in the wildfly-jar-maven-plugin, e.g.:

                                <channels>
                                    <channel>
                                        <manifest>
                                            <groupId>${wildfly.xp-channel.groupId}</groupId>
                                            <artifactId>${wildfly.xp-channel.artifactId}</artifactId>
                                            <version>${wildfly.xp-channel.version}</version>
                                        </manifest>
                                    </channel>
                                </channels>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @tommaso-borgato - I dropped just one comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants