feat(transport): TLS Client Hello fragmentation by fixed length #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fortuna
requested changes
Nov 28, 2023
jyyi1
changed the title
fortuna
reviewed
Nov 30, 2023
| inner := &collectStreamDialer{} | ||
| d, err := NewFixedLenStreamDialer(inner, 3) // Further split msg[:8] mentioned below into msg[:3] + msg[3:8] | ||
| require.NoError(t, err) | ||
| d, err = NewFixedLenStreamDialer(d, 8) // Further split msg[:16] mentioned below into msg[:8] + msg[8:16] |
There was a problem hiding this comment.
This works different from the TCP split.
If you do split:3|split:8, you end up with [3][5][...], because it's the absolute position.
Your code for tlsfrag:3|tlsfrag:8 is doing [3][8][...].
Perhaps we should align that behavior, otherwise it's surprising.
I find it more helpful to use an absolute number, as it makes it easier to specify them.
There was a problem hiding this comment.
I think I'm doing the absolute value as well. See the four fragmented packets above: frag1, frag2, frag3 and frag4, they are of lengths: [3][5][8][...].
And the config would be tlsfrag:3|tlsfrag:8|tlsfrag:16 (or tlsfrag:3|tlsfrag:8|tlsfrag:-3 since the total message size is 19).
fortuna
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
NewFixedBytesStreamDialerthat accepts a fixedsplitBytesto fragment the Client Hello message:splitBytes > 0: split a fixed leading bytes to two records:msg[:splitBytes]andmsg[splitBytes:]splitBytes < 0: split a fixed trailing bytes to two records:msg[:len(msg)-abs(splitBytes)]andmsg[len(msg)-abs(splitBytes):]splitBytes = 0: no splitThe function will be used in #135 .