Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): config for TLS fragmentation by fixed bytes #135

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Nov 28, 2023

This PR introduces tlsfrag:<len> to the config format.

@@ -93,6 +94,14 @@ func newStreamDialerFromPart(innerDialer transport.StreamDialer, oneDialerConfig
case "tls":
return newTlsStreamDialerFromURL(innerDialer, url)

case "tlsfrag":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should align with the tcp fragmentation. I don't think it makes sense to have both.
Should we rename split to frag? We'll need to update the documentation.
We could also make frag be a synonym for split and deprecate split.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename split to frag since this document also uses the term TCP Fragmentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking to @daniellacosse , and we think it's better if we have a actual word, specially given "frag" has its own, different meaning.
So we should settle on "fragment" or "split", but that can be in another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in this case I would prefer split cuz fragmentation is too long.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be fragment as well, as a verb

x/config/config.go Show resolved Hide resolved
x/config/config.go Outdated Show resolved Hide resolved
@jyyi1 jyyi1 requested a review from fortuna December 8, 2023 22:52
@jyyi1 jyyi1 marked this pull request as ready for review December 8, 2023 22:52
@@ -93,6 +94,14 @@ func newStreamDialerFromPart(innerDialer transport.StreamDialer, oneDialerConfig
case "tls":
return newTlsStreamDialerFromURL(innerDialer, url)

case "tlsfrag":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking to @daniellacosse , and we think it's better if we have a actual word, specially given "frag" has its own, different meaning.
So we should settle on "fragment" or "split", but that can be in another PR.

@jyyi1 jyyi1 merged commit 6d1cc39 into main Dec 13, 2023
6 checks passed
@jyyi1 jyyi1 deleted the junyi/tls-fixed-frag-config branch December 13, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants