-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(example): config for TLS fragmentation by fixed bytes #135
Conversation
@@ -93,6 +94,14 @@ func newStreamDialerFromPart(innerDialer transport.StreamDialer, oneDialerConfig | |||
case "tls": | |||
return newTlsStreamDialerFromURL(innerDialer, url) | |||
|
|||
case "tlsfrag": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should align with the tcp fragmentation. I don't think it makes sense to have both.
Should we rename split
to frag
? We'll need to update the documentation.
We could also make frag
be a synonym for split
and deprecate split
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rename split
to frag
since this document also uses the term TCP Fragmentation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking to @daniellacosse , and we think it's better if we have a actual word, specially given "frag" has its own, different meaning.
So we should settle on "fragment" or "split", but that can be in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, in this case I would prefer split
cuz fragmentation
is too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be fragment
as well, as a verb
@@ -93,6 +94,14 @@ func newStreamDialerFromPart(innerDialer transport.StreamDialer, oneDialerConfig | |||
case "tls": | |||
return newTlsStreamDialerFromURL(innerDialer, url) | |||
|
|||
case "tlsfrag": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking to @daniellacosse , and we think it's better if we have a actual word, specially given "frag" has its own, different meaning.
So we should settle on "fragment" or "split", but that can be in another PR.
This PR introduces
tlsfrag:<len>
to the config format.