Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rwd/qa #4636

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Rwd/qa #4636

merged 5 commits into from
Nov 22, 2023

Conversation

eshark9312
Copy link
Contributor

@eshark9312 eshark9312 commented Nov 21, 2023

closes #4628, #4629, #4630, #4631

  • I did not update Working Group/My Applications, My Roles in mobile, because these pages can't be available without membership, same as the My Profile page is removed.
  • And I did not follow the design for Past proposals filter, because the filter from the design is too tight so the dropdown is broken.
  • IMO the issues with Forum acivities and CK editor header are not from responsive design. but the common issues, so I think it can be a separate issue from RWD.

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Nov 22, 2023 3:58pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Nov 22, 2023 3:58pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Nov 22, 2023 3:58pm

@eshark9312
Copy link
Contributor Author

@polikosi
Some modals like MemberDetail should be shown even in mobile.
#4577 (comment)

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshark9312 thank you for addressing these so quickly.

TBH it's a bit tricky to review this PR which mostly touches styles. The code looks good and you made some really good choices, however the WGs table header row is broken. Since this table serves as a homepage in Pioneer it really should be fixed:

Screenshot from 2023-11-21 17-28-49

@polikosi
Copy link
Collaborator

Good job, but here are a few more minor issues

image

image

1440px
According to design voting result should be use Extra large variant.
image

Announce candidacy

Sidebar should be set to 220px
image

Announce candidacy: Reward account

Sidebar should be set to 220px
image

Announce candidacy: Candidate profile

Sidebar should be set to 220px
image

@eshark9312
Copy link
Contributor Author

@polikosi
According to the design, extra large variant of voting result have total stake and revealed votes column separate from the progress bar, but my contributed votes field is missed in the design, so I think we don't need to follow the design.

@eshark9312 eshark9312 requested a review from thesan November 22, 2023 15:23
@eshark9312 eshark9312 mentioned this pull request Nov 22, 2023
Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thesan thesan merged commit 5be8f61 into Joystream:dev Nov 22, 2023
4 checks passed
@polikosi
Copy link
Collaborator

polikosi commented Nov 22, 2023

@eshark9312 Hi, man. Here are a few new more minor issues)

1024px
can you do in 3 rows or something similar if possible (more readable)
image

It would be nice if it was centered
image

1440, 1440+px
image
The same problem with "Vote" button
image

image

It would be nice if it was centered or on one side
image

can I add to rwd this one?
image

@chrlschwb chrlschwb added qa-task community-dev issue suitable for community-dev pipeline labels Nov 22, 2023
@eshark9312
Copy link
Contributor Author

@polikosi
In the Announce Candidacy Modal, there is no enough space to implement the design when the balance value is too long.
IMO we can treat it with small variant of account selector.
And the last issue you mentioned is not a bug.

@polikosi
Copy link
Collaborator

@eshark9312 great job, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply for a role: Form
4 participants