-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rwd/qa #4636
Rwd/qa #4636
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@polikosi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eshark9312 thank you for addressing these so quickly.
TBH it's a bit tricky to review this PR which mostly touches styles. The code looks good and you made some really good choices, however the WGs table header row is broken. Since this table serves as a homepage in Pioneer it really should be fixed:
@polikosi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@eshark9312 Hi, man. Here are a few new more minor issues) 1024px It would be nice if it was centered 1440, 1440+px |
@polikosi |
@eshark9312 great job, thanks |
closes #4628, #4629, #4630, #4631
Working Group/My Applications, My Roles
in mobile, because these pages can't be available without membership, same as theMy Profile
page is removed.Past proposals filter
, because the filter from the design is too tight so the dropdown is broken.Forum acivities
andCK editor header
are not from responsive design. but the common issues, so I think it can be a separateissue
from RWD.